This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
add opencv support to Dockerfile #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cv2 is used by predictor.py, so it's required
facebook-github-bot
added
the
CLA Signed
|
cc. @miguelvr |
|
I would prefer just to keep it in conda, as it reduces the boilerplate and guarantees a correct installation |
miguelvr
suggested changes
Nov 22, 2018
|
@miguelvr I have changed to conda. But I wonder why you install ninja, yacs, cython, matplotlib through pip? |
|
@keineahnung2345 that's the default requirements for the installation for those libs, and is what we recommend in the installation. |
|
@keineahnung2345 basically I just put it as in the INSTALL.md for clarity. The benefit of installing opencv through conda is just to avoid the clutter of all the dependencies it has |
nprasad2021
pushed a commit
to nprasad2021/maskrcnn-benchmark
that referenced
this pull request
Jan 29, 2019
* add opencv support to Dockerfile cv2 is used by predictor.py, so it's required * install opencv-python from conda
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cv2 is used by predictor.py, so it's required